Skip to content

Add a tooltip to column headers with the content of the descriptor #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented May 9, 2025

What

Title.

TODO:

  • validate design
  • provide more explanation on stuff?
  • happy with the button to copy? (note the info message feedback)

cc @gavrelina

image image image

@abey79 abey79 added ui concerns graphical user interface do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels May 9, 2025
Copy link

github-actions bot commented May 9, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
17eca38 https://rerun.io/viewer/pr/9947 +nightly +main

Note: This comment is updated whenever you push a commit.

Base automatically changed from antoine/partition-table-col-viz to main May 19, 2025 12:25
@abey79 abey79 force-pushed the antoine/column-metadata-ui branch from 1080cfd to 1142310 Compare May 19, 2025 14:11
@abey79 abey79 removed the do-not-merge Do not merge this PR label May 19, 2025
@abey79 abey79 marked this pull request as ready for review May 19, 2025 14:17
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gavrelina
Copy link
Member

gavrelina commented May 19, 2025

Nice! also love the function of the copy via button!

  • Let's make it even more discoverable by adding an icon in front:
image
  • since we have an icon we don't need to differentiate the colors of values, so let's make them all a bit lighter (like you have a button), this will also increase readability
  • finally, for the very long popus + more information on stuff: we shall add a max width and truncate. but still have a way to see the whole text, i.e. in the side panel (when we will have it 👀). Until then I think this is OK!
  • I have also assumed that every of those params has a way to be set via code?

@abey79
Copy link
Member Author

abey79 commented May 20, 2025

  • I have also assumed that every of those params has a way to be set via code?

Well, more or less, eventually, some indirectly 😬 TBH this is a rather low-level information. These view should be adapted to exactly match the sorbet spec when we publish it.

@abey79 abey79 merged commit 77dbc99 into main May 20, 2025
37 of 40 checks passed
@abey79 abey79 deleted the antoine/column-metadata-ui branch May 20, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants